[polly] Add diagnostic remark for ReportVariantBasePtr

[Andreas Simbuerger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



On 06/26/2014 04:00 PM, Tobias Grosser wrote:
> On 26/06/2014 15:38, Andreas Simbuerger wrote:
>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
>> 
>> At the moment the DebugLoc is derived from the BaseValue. I'm not
>> 100% sure if the resulting DebugLoc corresponds to the A or the
>> (A->b) BaseValue.
> 
> Possibly A->b.

Yep, I meant 100%-sure from the output of the DebugLoc ;-).

> 
>> As far as I can tell, both would map to the same source location
>> in the debug-metadata.
> 
> The caret diagnostic points for me at the beginning of the line.
> This is good. If we ever figure out how to get the precise column
> location, that would be amazing.

That's what I would love to have. But well, so far it should be
helpful enough. ;-)

> 
> Also, I figured that I need to add -polly-detect-track-failures to
> get the missed optimizations output. As the possibly expensive
> formatting is done afterwards, I wonder if it would make sense to
> enable it by default?
> 

You mean tracking failures? Sure why not, by default it's only
tracking one error per region anyway. Shouldn't be too bad.

Be careful with -keep-going support though, it is buggy. I have a fix
ready, but did not generate a test-case yet.
The bug is simple: If we have a ValidRegion without errors in
keep-going mode, there is no check for the absence of errors
during expansion, so we will expand to a bigger region than allowed,
which is bad.

Cheers,
Andreas

> Cheers, Tobias

- -- 
Andreas Simbürger
University of Passau - Programming Group
http://www.infosun.fim.uni-passau.de/cl/staff/simbuerger/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJTrClXAAoJELS7a/6Ti2HY6fYH/32tgQ8sXyaxfAUqsyhfpIJD
5GNS4plTjJbrk+ln7/ay4WGVOLsVDhTyvqV0Qm1ysqa0x6aBO9DMJqJvyrvYl1Vi
XZYqoVBpD9JnJ+DVgogJhum4EGQZhfiHwKqOgt1Y9YhdUXWUVS4ge9ohbl8fRHrw
ogZoiV2TAORlYpsbqmAt8TLR4D3xaNqYUkf27GLAQ1urIhRe/qYz8xabKxG6n/Iq
7Oym8inua+B8FnOhobe5NaPY/nxKP4TSw+aqV3C/wiOA29fWE3/KPexZf5GM1sbS
pdngxhTsJYezzO2SmxeOKrAn1g8WiMY7CambogogXbYf/sRHU7xAoi8nMyk+gY4=
=mkmx
-----END PGP SIGNATURE-----