Introduce StringBuilder utility around raw_string_ostream

Alp Toker alp at nuanti.com
Wed Jun 25 17:52:02 PDT 2014


On 26/06/2014 03:16, Chandler Carruth wrote:
>
> On Thu, Jun 26, 2014 at 2:09 AM, Alp Toker <alp at nuanti.com 
> <mailto:alp at nuanti.com>> wrote:
>
>     I've made that change, plus a couple more updated uses, and landed
>     this in r211749.
>
>
> I don't understand why.
>
> I think my objection to the design direction stands, but I'm tired of 
> arguing pointlessly so I'm not going to restate things.

I actually do care about your suggestion Chandler.

It's my understanding that, if we get that alternative scheme to work at 
some point and agree it's an improvement, it'll be entirely compatible 
with the important bug fixes and malloc reduction enabled by this 
commit, which is where the value lies.

Alp.

-- 
http://www.nuanti.com
the browser experts




More information about the llvm-commits mailing list