[PATCH] ARM: Fix TPsoft for Thumb mode

Renato Golin renato.golin at linaro.org
Tue Jun 24 04:17:47 PDT 2014


================
Comment at: lib/Target/ARM/ARMExpandPseudoInsts.cpp:934
@@ +933,3 @@
+                       TII->get( ARM::tBL))
+               .addImm((unsigned)ARMCC::AL).addReg(0)
+               .addExternalSymbol("__aeabi_read_tp", 0);
----------------
Is this to cope with IT blocks?

================
Comment at: lib/Target/ARM/ARMInstrInfo.td:5118
@@ +5117,3 @@
+// is defined in "ARMInstrThumb.td".
+let Predicates = [IsARM] in {
+  let isCall = 1,
----------------
Is this really necessary? I'd have thought that everything in here is ARM anyway, plus the instruction is different (tTPsoft instead of TPsoft).

http://reviews.llvm.org/D4230






More information about the llvm-commits mailing list