[PATCH] Add new debug kind LocTrackingOnly.

Diego Novillo dnovillo at google.com
Mon Jun 23 14:29:59 PDT 2014


On Mon, Jun 23, 2014 at 4:31 PM, David Blaikie <dblaikie at gmail.com> wrote:

> ================
> Comment at: include/llvm/IR/DIBuilder.h:112
> @@ +111,3 @@
> +    /// @param Kind     The kind of debug information to generate.
> +    /// @param EmitDebugInfo   A boolean flag which indicates whether
> debug
> +    ///                        information should be written to the final
> ----------------
> I wonder if there's a less vague name we could use for this parameter, but
> I haven't thought of a better one yet. (I imagine inverted would make more
> sense - true for "use this weird thing where we make metadata nodes but
> don't add the CUs to the list" - but still don't know what we'd name it)
>

Not sure what you consider vague about it. In my mind, this distinguishes
the generation of the debug info from its emission.  I'll gladly rename it
to something else if you can think of another way of naming this flow.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140623/8985ea3a/attachment.html>


More information about the llvm-commits mailing list