<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 23, 2014 at 4:31 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank" class="cremed">dblaikie@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">================<br>
Comment at: include/llvm/IR/DIBuilder.h:112<br>
@@ +111,3 @@<br>
<div class="">+   /// @param Kind   The kind of debug information to generate.<br>
</div><div class="">+   /// @param EmitDebugInfo  A boolean flag which indicates whether debug<br>
+ Â Â /// Â Â Â Â Â Â Â Â Â Â Â Â information should be written to the final<br>
</div>----------------<br>
I wonder if there's a less vague name we could use for this parameter, but I haven't thought of a better one yet. (I imagine inverted would make more sense - true for "use this weird thing where we make metadata nodes but don't add the CUs to the list" - but still don't know what we'd name it)<br>
</blockquote><div><br></div><div>Not sure what you consider vague about it. In my mind, this distinguishes the generation of the debug info from its emission. Â I'll gladly rename it to something else if you can think of another way of naming this flow.</div>
</div></div></div>