[PATCH] [AArch64] Add instruction selection support for ADDV (add across vector).

Tilmann Scheller t.scheller at samsung.com
Thu Jun 19 13:12:47 PDT 2014


Hi Evan,

sounds good to me, I didn't know that we have generic infrastructure for
this.

Regards,

Tilmann

-----Original Message-----
From: Evan Cheng [mailto:evan.cheng at apple.com] 
Sent: Thursday, June 19, 2014 9:12 PM
To: Tilmann Scheller
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] [AArch64] Add instruction selection support for ADDV
(add across vector).

I would expect / prefer to see this being handled with SLP vectorization.
That is, SLP vectorizer should match this to horizontal reduction fadd and
than isel can map it to the right instruction. That way, we have a more
general solution for all targets.

I see x86 isel has code to handle horizontal float add / sub.

Evan

On Jun 17, 2014, at 9:24 AM, Tilmann Scheller <t.scheller at samsung.com>
wrote:

> Hi,
> 
> attached is a patch for PR20035 (instruction selection support for
horizontal adds).
> 
> Regards,
> 
> Tilmann
> 
>
<0001-AArch64-Add-instruction-selection-support-for-ADDV-a.patch>___________
____________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list