[llvm] r211080 - Expose ValueMap's mutex type as a typedef instead of a sys::Mutex.

[Zachary Turner]

Well the class holds only a pointer to a sys::Mutex, so in theory it can be
used in any many possible ways.  I think this unit test is only intended to
test the class itself, not clients of the class.


On Tue, Jun 17, 2014 at 11:17 AM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> On 17 June 2014 13:53, Zachary Turner <zturner at google.com> wrote:
> > If you want a hint, everywhere is a recursive mutex except, as far as I
> can
> > tell, in the ValueMapTest in unittests, which uses a non recursive mutex.
> > Because recursive seems to be the most common, i made it the default
> > template argument type so that an existing user will not have to change
> his
> > syntax to compile with the new template arg.
>
>
> That sounds like a bug in the test. Why is the test doing something
> different from the actual code using the class?
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140617/44929f64/attachment.html>