[llvm] r211080 - Expose ValueMap's mutex type as a typedef instead of a sys::Mutex.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Jun 17 11:17:58 PDT 2014


On 17 June 2014 13:53, Zachary Turner <zturner at google.com> wrote:
> If you want a hint, everywhere is a recursive mutex except, as far as I can
> tell, in the ValueMapTest in unittests, which uses a non recursive mutex.
> Because recursive seems to be the most common, i made it the default
> template argument type so that an existing user will not have to change his
> syntax to compile with the new template arg.


That sounds like a bug in the test. Why is the test doing something
different from the actual code using the class?

Cheers,
Rafael



More information about the llvm-commits mailing list