[PATCH] [AArch64] Condition codes AL and NV are invalid in the aliases that use inverted condition codes

Artyom Skrobov Artyom.Skrobov at arm.com
Tue Jun 10 06:20:56 PDT 2014


>  ValidateMCOperand -> validateMCOperand (or possibly
> validateMCOperandForAlias or something).

This actually gets concatenated into something like "AArch64AppleInstPrinterValidateMCOperand"; "ValidateMCOperand" never stands on its own in the generated .inc files.

> + Could you put braces around each case? It would allow people to
> declare variables in the fragment if they wanted.
>
> The others look fine too.

Thanks! Added the braces and committed r210526, r210527, r210528








More information about the llvm-commits mailing list