[PATCH] [AArch64] Condition codes AL and NV are invalid in the aliases that use inverted condition codes

Tim Northover t.p.northover at gmail.com
Tue Jun 10 04:22:53 PDT 2014


Hi Artyom,

Thanks for the updated patch. I've got two suggestions, but would be
reasonably happy for a commit anyway:

+ ValidateMCOperand -> validateMCOperand (or possibly
validateMCOperandForAlias or something).
+ Could you put braces around each case? It would allow people to
declare variables in the fragment if they wanted.

The others look fine too.

Cheers.

Tim.



More information about the llvm-commits mailing list