[PATCH] Change base mutex implementations to use STL-provided mutexes

Chandler Carruth chandlerc at gmail.com
Fri Jun 6 17:56:24 PDT 2014


On Fri, Jun 6, 2014 at 1:15 PM, Aaron Ballman <aaron.ballman at gmail.com>
wrote:

> For the time I've been doing Win32 work on Clang and LLVM, the policy
> has been that Windows includes should live in the implementation
> files, not in the header files. Of course, there are exceptions to
> every rule -- I just don't think this one is an exception.
>

I think that the exception are the windows headers which bring too much
into the global namespace. We should not be treating poorly behaved system
headers as the rule. For example, <sys/stat.h>, <unistd.h>, etc. all seem
reasonable to include into headers provided portable alternatives are
provided and used on non-POSIX platforms.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140606/dc6c1700/attachment.html>


More information about the llvm-commits mailing list