[PATCH] [AArch64] Fix MC assertion failures with certain invalid instructions
Tim Northover
t.p.northover at gmail.com
Thu May 29 03:49:16 PDT 2014
Hi Artyom,
On 29 May 2014 11:36, Artyom Skrobov <Artyom.Skrobov at arm.com> wrote:
> We have identified two MC issues in the newly-merged AArch64 backend.
> These lead to assertion failures when handling certain invalid instructions.
For the inverted condition code patch, I think it'd be very good to
comment what instruction that might be interpreted as. Also, if it's
undefined it should have a "# CHECK: invalid instruction encoding"
line associated (otherwise LLVM could start disassembling it, or any
other instruction in that file, and we'd not notice). If not, it
should be tested in a different file.
The too few operands patch looks fine.
Cheers.
Tim.
More information about the llvm-commits
mailing list