[PATCH] [asan] disable fast unwind on ARM

Kostya Serebryany kcc at google.com
Sun May 18 23:37:35 PDT 2014


We do use fast unwind on Android ARM -- it is a performance-critical
feature, please don't disable it, but fix instead.
eugenis@ knows the details.


On Sat, May 17, 2014 at 5:44 AM, Greg Fitzgerald <gregf at codeaurora.org>wrote:

> Hi samsonov,
>
> Fast unwind is disabled for aarch64.  Following suit.  This patch fixes
> the following lit tests:
>
> Linux/malloc_delete_mismatch.cc
> Posix/start-deactivated.cc
> deep_stack_uaf.cc
> double-free.cc
> invalid-free.cc
> large_func_test.cc
>
> http://reviews.llvm.org/D3814
>
> Files:
>   lib/sanitizer_common/sanitizer_stacktrace.h
>
> Index: lib/sanitizer_common/sanitizer_stacktrace.h
> ===================================================================
> --- lib/sanitizer_common/sanitizer_stacktrace.h
> +++ lib/sanitizer_common/sanitizer_stacktrace.h
> @@ -21,7 +21,7 @@
>
>  #if SANITIZER_LINUX && (defined(__aarch64__) || defined(__powerpc__) || \
>                          defined(__powerpc64__) || defined(__sparc__) || \
> -                        defined(__mips__))
> +                        defined(__mips__) || defined(__arm__))
>  # define SANITIZER_CAN_FAST_UNWIND 0
>  #elif SANITIZER_WINDOWS
>  # define SANITIZER_CAN_FAST_UNWIND 0
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140519/d6a303d3/attachment.html>


More information about the llvm-commits mailing list