<div dir="ltr">We do use fast unwind on Android ARM -- it is a performance-critical feature, please don't disable it, but fix instead. <div>eugenis@ knows the details. </div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Sat, May 17, 2014 at 5:44 AM, Greg Fitzgerald <span dir="ltr"><<a href="mailto:gregf@codeaurora.org" target="_blank">gregf@codeaurora.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi samsonov,<br>
<br>
Fast unwind is disabled for aarch64.  Following suit.  This patch fixes the following lit tests:<br>
<br>
Linux/malloc_delete_mismatch.cc<br>
Posix/start-deactivated.cc<br>
deep_stack_uaf.cc<br>
double-free.cc<br>
invalid-free.cc<br>
large_func_test.cc<br>
<br>
<a href="http://reviews.llvm.org/D3814" target="_blank">http://reviews.llvm.org/D3814</a><br>
<br>
Files:<br>
  lib/sanitizer_common/sanitizer_stacktrace.h<br>
<br>
Index: lib/sanitizer_common/sanitizer_stacktrace.h<br>
===================================================================<br>
--- lib/sanitizer_common/sanitizer_stacktrace.h<br>
+++ lib/sanitizer_common/sanitizer_stacktrace.h<br>
@@ -21,7 +21,7 @@<br>
<br>
 #if SANITIZER_LINUX && (defined(__aarch64__) || defined(__powerpc__) || \<br>
                         defined(__powerpc64__) || defined(__sparc__) || \<br>
-                        defined(__mips__))<br>
+                        defined(__mips__) || defined(__arm__))<br>
 # define SANITIZER_CAN_FAST_UNWIND 0<br>
 #elif SANITIZER_WINDOWS<br>
 # define SANITIZER_CAN_FAST_UNWIND 0<br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>