[compiler-rt] r208746 - Add target flags to ubsan tests

[Greg Fitzgerald]

Good point.  Actually, it’s there already.  I needed to change “test/ubsan/lit.common.cfg” but not “test/ubsan/lit.site.cfg.in”.  Will fix.

 

-Greg

 

 

From: Alexey Samsonov [mailto:samsonov at google.com] 
Sent: Tuesday, May 13, 2014 5:59 PM
To: Greg Fitzgerald
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [compiler-rt] r208746 - Add target flags to ubsan tests

 

Why this is not added to common lit config (test/lit.common.configured.in) instead?

 

On Tue, May 13, 2014 at 5:46 PM, Greg Fitzgerald <gregf at codeaurora.org> wrote:

Author: garious
Date: Tue May 13 19:46:01 2014
New Revision: 208746

URL: http://llvm.org/viewvc/llvm-project?rev=208746 <http://llvm.org/viewvc/llvm-project?rev=208746&view=rev> &view=rev
Log:
Add target flags to ubsan tests

Modified:
    compiler-rt/trunk/test/ubsan/lit.common.cfg
    compiler-rt/trunk/test/ubsan/lit.site.cfg.in

Modified: compiler-rt/trunk/test/ubsan/lit.common.cfg
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/lit.common.cfg?rev=208746 <http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/lit.common.cfg?rev=208746&r1=208745&r2=208746&view=diff> &r1=208745&r2=208746&view=diff
==============================================================================
--- compiler-rt/trunk/test/ubsan/lit.common.cfg (original)
+++ compiler-rt/trunk/test/ubsan/lit.common.cfg Tue May 13 19:46:01 2014
@@ -28,6 +28,8 @@ else:
 def build_invocation(compile_flags):
   return " " + " ".join([config.clang] + compile_flags) + " "

+target_cflags = [get_required_attr(config, "target_cflags")]
+clang_ubsan_cflags += target_cflags
 clang_ubsan_cxxflags = config.cxx_mode_flags + clang_ubsan_cflags

 # Define %clang and %clangxx substitutions to use in test RUN lines.

Modified: compiler-rt/trunk/test/ubsan/lit.site.cfg.in
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/lit.site.cfg.in?rev=208746 <http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/lit.site.cfg.in?rev=208746&r1=208745&r2=208746&view=diff> &r1=208745&r2=208746&view=diff
==============================================================================
--- compiler-rt/trunk/test/ubsan/lit.site.cfg.in (original)
+++ compiler-rt/trunk/test/ubsan/lit.site.cfg.in Tue May 13 19:46:01 2014
@@ -3,6 +3,7 @@ lit_config.load_config(config,  <mailto:%22 at COMPILE%0b%0b # Tool-specific config options. config.ubsan_lit_test_mode = > "@COMPILE

 # Tool-specific config options.
 config.ubsan_lit_test_mode = "@UBSAN_LIT_TEST_MODE@"
+config.target_cflags = "@COMPILER_RT_TEST_COMPILER_CFLAGS@"

 # Load tool-specific config that would do the real work.
 lit_config.load_config(config, "@UBSAN_LIT_TESTS_DIR@/lit.common.cfg")


_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





 

-- 

Alexey Samsonov, Mountain View, CA

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140513/8d38bcc1/attachment.html>