<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Good point. Actually, it’s there already. I needed to change “test/ubsan/lit.common.cfg” but not “test/ubsan/lit.site.cfg.in”. Will fix.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>-Greg<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Alexey Samsonov [mailto:samsonov@google.com] <br><b>Sent:</b> Tuesday, May 13, 2014 5:59 PM<br><b>To:</b> Greg Fitzgerald<br><b>Cc:</b> llvm-commits@cs.uiuc.edu<br><b>Subject:</b> Re: [compiler-rt] r208746 - Add target flags to ubsan tests<o:p></o:p></span></p><p class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>Why this is not added to common lit config (test/<a href="http://lit.common.configured.in">lit.common.configured.in</a>) instead?<o:p></o:p></p></div><div><p class=MsoNormal style='margin-bottom:12.0pt'><o:p> </o:p></p><div><p class=MsoNormal>On Tue, May 13, 2014 at 5:46 PM, Greg Fitzgerald <<a href="mailto:gregf@codeaurora.org" target="_blank">gregf@codeaurora.org</a>> wrote:<o:p></o:p></p><p class=MsoNormal>Author: garious<br>Date: Tue May 13 19:46:01 2014<br>New Revision: 208746<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=208746&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=208746&view=rev</a><br>Log:<br>Add target flags to ubsan tests<br><br>Modified:<br> compiler-rt/trunk/test/ubsan/lit.common.cfg<br> compiler-rt/trunk/test/ubsan/<a href="http://lit.site.cfg.in" target="_blank">lit.site.cfg.in</a><br><br>Modified: compiler-rt/trunk/test/ubsan/lit.common.cfg<br>URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/lit.common.cfg?rev=208746&r1=208745&r2=208746&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/lit.common.cfg?rev=208746&r1=208745&r2=208746&view=diff</a><br>==============================================================================<br>--- compiler-rt/trunk/test/ubsan/lit.common.cfg (original)<br>+++ compiler-rt/trunk/test/ubsan/lit.common.cfg Tue May 13 19:46:01 2014<br>@@ -28,6 +28,8 @@ else:<br> def build_invocation(compile_flags):<br> return " " + " ".join([config.clang] + compile_flags) + " "<br><br>+target_cflags = [get_required_attr(config, "target_cflags")]<br>+clang_ubsan_cflags += target_cflags<br> clang_ubsan_cxxflags = config.cxx_mode_flags + clang_ubsan_cflags<br><br> # Define %clang and %clangxx substitutions to use in test RUN lines.<br><br>Modified: compiler-rt/trunk/test/ubsan/<a href="http://lit.site.cfg.in" target="_blank">lit.site.cfg.in</a><br>URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/lit.site.cfg.in?rev=208746&r1=208745&r2=208746&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/ubsan/lit.site.cfg.in?rev=208746&r1=208745&r2=208746&view=diff</a><br>==============================================================================<br>--- compiler-rt/trunk/test/ubsan/<a href="http://lit.site.cfg.in" target="_blank">lit.site.cfg.in</a> (original)<br>+++ compiler-rt/trunk/test/ubsan/<a href="http://lit.site.cfg.in" target="_blank">lit.site.cfg.in</a> Tue May 13 19:46:01 2014<br>@@ -3,6 +3,7 @@ lit_config.load_config(config, <a href="mailto:%22@COMPILE%0b%0b # Tool-specific config options. config.ubsan_lit_test_mode = "@UBSAN_LIT_TEST_MODE@">"@COMPILE<br><br> # Tool-specific config options.<br> config.ubsan_lit_test_mode = "@UBSAN_LIT_TEST_MODE@</a>"<br>+config.target_cflags = "@COMPILER_RT_TEST_COMPILER_CFLAGS@"<br><br> # Load tool-specific config that would do the real work.<br> lit_config.load_config(config, "@UBSAN_LIT_TESTS_DIR@/lit.common.cfg")<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><o:p></o:p></p></div><p class=MsoNormal><br><br clear=all><o:p></o:p></p><div><p class=MsoNormal><o:p> </o:p></p></div><p class=MsoNormal>-- <o:p></o:p></p><div><div><p class=MsoNormal>Alexey Samsonov, Mountain View, CA<o:p></o:p></p></div></div></div></div></body></html>