[PATCH] Wrap .subsections_via_symbols directives in #if __APPLE__

Saleem Abdulrasool compnerd at compnerd.org
Fri May 9 22:37:03 PDT 2014


I think that adding that to DEFINE_COMPILERRT_PRIVATE_FUNCTION should be
okay.  The only place that this is used currently is when you are defining
a private function.

On Fri, May 9, 2014 at 6:39 PM, Jon Roelofs <jonathan at codesourcery.com>wrote:

> Reed, care to bikeshed on a name?  I'm drawing a blank.
>
> Another option I considered was to add FILE_LEVEL_DIRECTIVE to the
> definition of DEFINE_COMPILERRT_PRIVATE_FUNCTION (just like
> DEFINE_COMPILERRT_FUNCTION has), and delete all of these.  I'm not sure if
> that is correct though as there are a few other builtins that don't have
> .subsections_via_symbols.
>
> http://reviews.llvm.org/D3708
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140509/f6bea47d/attachment.html>


More information about the llvm-commits mailing list