[PATCH] Implement Named Register Global Variables in LLVM

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon May 5 16:30:17 PDT 2014


On 5 May 2014 16:13, Renato Golin <renato.golin at linaro.org> wrote:
> Good point. I'll add some negative tests.
>
> About the non-allocatable registers, to be fair, the *only* register that is accepted right now is the stack pointer. Should I add to each architecture the list of non-allocatable ones, too? Or should I just update the docs saying that, for now, only the stack pointer works?

It is probably a good idea to say that non-allocatable registers are
not supported. Don't include a "for now", since supporting that would
be a far more contentious change, and we shouldn't give the impression
it is around the corner.

For the same reason, at least have a test showing that a
non-allocatable register errors and have a FIXME in the test about
providing a more explicit error about non-allocatable registers.

Saying that "for now" the only supported register is the stack pointer
is probably a good independent improvement.

Cheers,
Rafael




More information about the llvm-commits mailing list