[patch] Centralize the handling of the thumb bit

[Saleem Abdulrasool]

On Sun, Apr 27, 2014 at 5:53 PM, Rafael Espíndola <
rafael.espindola at gmail.com> wrote:

> The attached patch centralizes the handling of the thumb bit around
> MCStreamer::isThumbFunc and makes isThumbFunc handle aliases.
>
> This fixes a corner case, but the main advantage is having just one
> way to check if a MCSymbol is thumb or not. This should still be
> refactored to be ARM only, but at least now it is just one predicate
> that has to be refactored instead of 3 (isThumbFunc,
> ELF_Other_ThumbFunc, and SF_ThumbFunc.
>

Definitely an improvement over what was there.

Minor nit on your comment: "gas support" should be "gas supports".

LGTM!


> Cheers,
> Rafael
>



-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140429/c86d9152/attachment.html>