[patch] Centralize the handling of the thumb bit

Renato Golin renato.golin at linaro.org
Tue Apr 29 05:07:29 PDT 2014


Hi Rafael,

LGTM, thanks!

--renato

On 28 April 2014 01:53, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> The attached patch centralizes the handling of the thumb bit around
> MCStreamer::isThumbFunc and makes isThumbFunc handle aliases.
>
> This fixes a corner case, but the main advantage is having just one
> way to check if a MCSymbol is thumb or not. This should still be
> refactored to be ARM only, but at least now it is just one predicate
> that has to be refactored instead of 3 (isThumbFunc,
> ELF_Other_ThumbFunc, and SF_ThumbFunc.
>
> Cheers,
> Rafael
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>




More information about the llvm-commits mailing list