[PATCH] Fixed llvm-build when no targets are enabled.

Daniel Dunbar daniel at zuster.org
Fri Apr 18 10:31:21 PDT 2014


LGTM.

 - Daniel


On Fri, Apr 18, 2014 at 10:06 AM, Greg Fitzgerald <garious at gmail.com> wrote:

> Hi ddunbar,
>
> llvm-build fails when -DLLVM_TARGETS_TO_BUILD="".  This patch fixes it.
>
> http://reviews.llvm.org/D3428
>
> Files:
>   utils/llvm-build/llvmbuild/main.py
>
> Index: utils/llvm-build/llvmbuild/main.py
> ===================================================================
> --- utils/llvm-build/llvmbuild/main.py
> +++ utils/llvm-build/llvmbuild/main.py
> @@ -719,7 +719,9 @@
>          enable_targets = available_targets.values()
>      else:
>          # We support both space separated and semi-colon separated lists.
> -        if ' ' in opts.enable_targets:
> +        if opts.enable_targets == '':
> +            enable_target_names = []
> +        elif ' ' in opts.enable_targets:
>              enable_target_names = opts.enable_targets.split()
>          else:
>              enable_target_names = opts.enable_targets.split(';')
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140418/f114c578/attachment.html>


More information about the llvm-commits mailing list