<div dir="ltr">LGTM.<div><br></div><div> - Daniel</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Apr 18, 2014 at 10:06 AM, Greg Fitzgerald <span dir="ltr"><<a href="mailto:garious@gmail.com" target="_blank">garious@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi ddunbar,<br>
<br>
llvm-build fails when -DLLVM_TARGETS_TO_BUILD="".  This patch fixes it.<br>
<br>
<a href="http://reviews.llvm.org/D3428" target="_blank">http://reviews.llvm.org/D3428</a><br>
<br>
Files:<br>
  utils/llvm-build/llvmbuild/main.py<br>
<br>
Index: utils/llvm-build/llvmbuild/main.py<br>
===================================================================<br>
--- utils/llvm-build/llvmbuild/main.py<br>
+++ utils/llvm-build/llvmbuild/main.py<br>
@@ -719,7 +719,9 @@<br>
         enable_targets = available_targets.values()<br>
     else:<br>
         # We support both space separated and semi-colon separated lists.<br>
-        if ' ' in opts.enable_targets:<br>
+        if opts.enable_targets == '':<br>
+            enable_target_names = []<br>
+        elif ' ' in opts.enable_targets:<br>
             enable_target_names = opts.enable_targets.split()<br>
         else:<br>
             enable_target_names = opts.enable_targets.split(';')<br>
</blockquote></div><br></div>