[PATCH] Fix bug 19437 - Only add discriminators for DWARF 4 and above.

[Diego Novillo]

On Thu, Apr 17, 2014 at 5:23 PM, Chandler Carruth <chandlerc at gmail.com>wrote:
>
>
> ================
> Comment at: include/llvm/IR/Module.h:606
> @@ +605,3 @@
> +
> +  /// Return Dwarf Version by checking module flags.
> +  unsigned getDwarfVersion() const;
> ----------------
> Go ahead and put a '\brief' on this.
>

Done.


>
> ================
> Comment at: include/llvm/IR/Module.h:607
> @@ +606,3 @@
> +  /// Return Dwarf Version by checking module flags.
> +  unsigned getDwarfVersion() const;
> +
> ----------------
> Any reason not to return the strongly typed enum?
>

I copied and pasted from the original implementation. From what I can tell,
the version number is an unsigned value. Dwarf.h is playing fast and loose
with this. The only strong enum is for the value '4'. Everything else is
just an integer.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140417/105c217c/attachment.html>