[PATCH] Fix bug 19437 - Only add discriminators for DWARF 4 and above.
Chandler Carruth
chandlerc at gmail.com
Thu Apr 17 14:23:05 PDT 2014
Ok, nits from the peanut gallery, but feel free to ignore me and listen to the real reviewers. ;]
/me runs away
================
Comment at: include/llvm/IR/Module.h:606
@@ +605,3 @@
+
+ /// Return Dwarf Version by checking module flags.
+ unsigned getDwarfVersion() const;
----------------
Go ahead and put a '\brief' on this.
================
Comment at: include/llvm/IR/Module.h:607
@@ +606,3 @@
+ /// Return Dwarf Version by checking module flags.
+ unsigned getDwarfVersion() const;
+
----------------
Any reason not to return the strongly typed enum?
http://reviews.llvm.org/D3413
More information about the llvm-commits
mailing list