[PATCH] R600/SI: Select BUILD_PAIR using SSrc instead of VSrc.

Matt Arsenault arsenm2 at gmail.com
Tue Apr 15 19:02:47 PDT 2014


On Apr 1, 2014, at 6:40 AM, Tom Stellard <tom at stellard.net> wrote:

> On Mon, Mar 31, 2014 at 05:49:50PM -0700, Matt Arsenault wrote:
>> The test changes are somewhat unfortunate. Instead of moving the immediate 0 directly into the VGPR, it is moved into an SGPR, and then that SGPR is copied. This is more or less OK since the 0 needs to be loaded anyway into the SGPR, but it would probably be better if it also just used the immediate 0 for the v_mov.
>> 
> 
> I have a similar patch here:
> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20140317/209824.html
> 
> But I think it makes sense to use SSrc_64 instead of SGPR_64 like you've
> done here.
> 
> There are a number of regressions related to these patches that I'm
> working on fixing now.  I'll let you know when this patch is safe to
> commit.
> 
> -Tom
> 

Some of these have gone in already, so is this OK now?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140415/eb2180d4/attachment.html>


More information about the llvm-commits mailing list