<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Apr 1, 2014, at 6:40 AM, Tom Stellard <<a href="mailto:tom@stellard.net">tom@stellard.net</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Mon, Mar 31, 2014 at 05:49:50PM -0700, Matt Arsenault wrote:<br><blockquote type="cite">The test changes are somewhat unfortunate. Instead of moving the immediate 0 directly into the VGPR, it is moved into an SGPR, and then that SGPR is copied. This is more or less OK since the 0 needs to be loaded anyway into the SGPR, but it would probably be better if it also just used the immediate 0 for the v_mov.<br><br></blockquote><br>I have a similar patch here:<br><a href="http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20140317/209824.html">http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20140317/209824.html</a><br><br>But I think it makes sense to use SSrc_64 instead of SGPR_64 like you've<br>done here.<br><br>There are a number of regressions related to these patches that I'm<br>working on fixing now. I'll let you know when this patch is safe to<br>commit.<br><br>-Tom<br><br></div></blockquote><div><br></div><div>Some of these have gone in already, so is this OK now?</div></div></body></html>