[lld] r205163 - [core] support .gnu.linkonce sections
Shankar Easwaran
shankare at codeaurora.org
Mon Mar 31 11:21:07 PDT 2014
On 3/31/2014 1:02 PM, Rui Ueyama wrote:
>
> I did not simply push back this patch but also pointed out some issues
> that were in your patch with a suggestion.
>
> My suggestion was to merge it with COMDAT group section if they share
> the same semantics. If COMDAT groups and .gnu.linkonce sections need
> to be distinguished only to detect collisions of different types, i'd
> be great if we can compartment that detail in a small piece of code in
> Resolver, rather than spreading typeGroupComdat||typeGnuLinkOnce at
> every if's. Can't you use name prefix ".gnu.linkonce" to detect one
> section is a .gnu.linkonce section? If not, can't you add a new
> attribute for it?
>
I dont want to make a comparison on section names in the resolver.
Adding an attribute as part of the contentType is what I exactly did in
the patch. I dont see gnu linkonce be associated with some other
attribute than contentType.
Thanks
Shankar Easwaran
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140331/471625e9/attachment.html>
More information about the llvm-commits
mailing list