<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 3/31/2014 1:02 PM, Rui Ueyama wrote:<br>
</div>
<blockquote
cite="mid:CAJENXgtrNKMSP0ANnkjBYtJnH2D=tJpXMqtk18vTTqDbBvZ3pg@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote"><br>
<div>I did not simply push back this patch but also pointed
out some issues that were in your patch with a suggestion.</div>
<div><br>
</div>
<div>My suggestion was to merge it with COMDAT group section
if they share the same semantics. If COMDAT groups and
.gnu.linkonce sections need to be distinguished only to
detect collisions of different types, i'd be great if we
can compartment that detail in a small piece of code in
Resolver, rather than spreading <span
style="font-family:arial,sans-serif;font-size:13px">typeGroupComdat||typeGnuLinkOnce
at every if's. Can't you use name prefix ".gnu.linkonce"
to detect one section is a .gnu.linkonce section? If
not, can't you add a new attribute for it?</span></div>
<div><br>
</div>
</div>
</div>
</div>
</blockquote>
I dont want to make a comparison on section names in the resolver.
Adding an attribute as part of the contentType is what I exactly did
in the patch. I dont see gnu linkonce be associated with some other
attribute than contentType.<br>
<br>
Thanks<br>
<br>
Shankar Easwaran<br>
<br>
<pre class="moz-signature" cols="72">--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation</pre>
</body>
</html>