[PATCH] [core] add support to resolve section groups.

[Shankar Kalpathi Easwaran]

================
Comment at: lib/ReaderWriter/YAML/ReaderWriterYAML.cpp:203
@@ +202,3 @@
+      return pos->second;
+    } else {
+      _io.setError(Twine("no such group name: ") + name);
----------------
Simon Atanasyan wrote:
> [[ http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return | Else after return ]]
Thanks for catching this. Fixed.

================
Comment at: lib/ReaderWriter/YAML/ReaderWriterYAML.cpp:216
@@ +215,3 @@
+      return pos->second;
+    } else {
+      _io.setError(Twine("no such group child: ") + name);
----------------
Simon Atanasyan wrote:
> [[ http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return | Else after return ]]
Fixed.

================
Comment at: lib/ReaderWriter/Native/WriterNative.cpp:44
@@ +43,3 @@
+      // handle each
+      // child atom.
+      if (defAtom->contentType() == DefinedAtom::typeGroupComdat) {
----------------
Simon Atanasyan wrote:
> Strange comment formatting. The last two lines too short.
I didnt notice after clang-format formatted it. Fixed.

================
Comment at: include/lld/Core/Resolver.h:70
@@ -69,1 +69,3 @@
 
+  /// \brief Add section group if it doesnot exist previously.
+  void maybeAddSectionGroup(const DefinedAtom &atom);
----------------
Simon Atanasyan wrote:
> Typo. s/doesnot/does not/
Fixed.


http://llvm-reviews.chandlerc.com/D3182