[PATCH] [core] add support to resolve section groups.
Simon Atanasyan
simon at atanasyan.com
Wed Mar 26 00:32:16 PDT 2014
LGTM with some minor comments.
================
Comment at: include/lld/Core/Resolver.h:70
@@ -69,1 +69,3 @@
+ /// \brief Add section group if it doesnot exist previously.
+ void maybeAddSectionGroup(const DefinedAtom &atom);
----------------
Typo. s/doesnot/does not/
================
Comment at: lib/ReaderWriter/Native/WriterNative.cpp:44
@@ +43,3 @@
+ // handle each
+ // child atom.
+ if (defAtom->contentType() == DefinedAtom::typeGroupComdat) {
----------------
Strange comment formatting. The last two lines too short.
================
Comment at: lib/ReaderWriter/YAML/ReaderWriterYAML.cpp:203
@@ +202,3 @@
+ return pos->second;
+ } else {
+ _io.setError(Twine("no such group name: ") + name);
----------------
[[ http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return | Else after return ]]
================
Comment at: lib/ReaderWriter/YAML/ReaderWriterYAML.cpp:216
@@ +215,3 @@
+ return pos->second;
+ } else {
+ _io.setError(Twine("no such group child: ") + name);
----------------
[[ http://llvm.org/docs/CodingStandards.html#don-t-use-else-after-a-return | Else after return ]]
http://llvm-reviews.chandlerc.com/D3182
More information about the llvm-commits
mailing list