[PATCH] [core] add support to resolve section groups.

Rui Ueyama ruiu at google.com
Tue Mar 25 15:45:53 PDT 2014



================
Comment at: lib/Core/Resolver.cpp:219
@@ +218,3 @@
+    // for the first time
+    if (isFirstTime) {
+      for (const Reference *r : atom) {
----------------
Shankar Kalpathi Easwaran wrote:
> Rui Ueyama wrote:
> > Is this the correct semantics? If it's not a COMDAT group, we have to report an error for duplicate section group, no?
> No. The typeGroupComdat atom has the list of all group child members. 
Yes, that's I know. But I don't think that answers my comment, I guess. Can you elaborate, please?


http://llvm-reviews.chandlerc.com/D3182



More information about the llvm-commits mailing list