[PATCH] [core] add support to resolve section groups.

Shankar Kalpathi Easwaran shankarke at gmail.com
Tue Mar 25 15:35:42 PDT 2014



================
Comment at: lib/Core/Resolver.cpp:216
@@ +215,3 @@
+  if (atom.contentType() == DefinedAtom::typeGroupComdat) {
+    bool isFirstTime = _symbolTable.addGroup(atom);
+    // Add all the group child members if the group is seen
----------------
Rui Ueyama wrote:
> Please make this piece of code a separate function ("maybeAddSectionGroup", maybe?) to keep the readability of this function.
Ok.

================
Comment at: lib/Core/Resolver.cpp:230
@@ +229,3 @@
+      }   // Iterate over references
+    }     // isFirstTime
+  } else {
----------------
Rui Ueyama wrote:
> Remove comments from the above three lines. We don't usually add comments like them.
Ok.


http://llvm-reviews.chandlerc.com/D3182



More information about the llvm-commits mailing list