[PATCH][ARM] Label offset crashes llvm integrated assembler

[Jiangning Liu]

Are you sure the fix in r203762 is correct? With the trunk, I got the
following result, and obviously, the immediate operand is incorrect.

Thanks,
-Jiangning

$ llvm-mc -triple=armv7-linux-gnuabi -filetype=obj test_label_offset.s -o
test_label_offset.o
$ arm-none-linux-gnueabi-objdump -dS test_label_offset.o

test_label_offset.o:     file format elf32-littlearm


Disassembly of section .text:

00000000 <l1-0x4>:
   0: e3520910 cmp r2, #16, 18 ; 0x40000
$ cat test_label_offset.s
.text
    cmp r2, #(l2 - l1) >> 6

l1:
l2:



2014-03-13 15:09 GMT+08:00 Saleem Abdulrasool <compnerd at compnerd.org>:

> On Wed, Mar 12, 2014 at 11:23 PM, Saleem Abdulrasool <
> compnerd at compnerd.org> wrote:
>
>> On Wed, Mar 12, 2014 at 11:12 PM, Jiangning Liu <liujiangning1 at gmail.com>wrote:
>>
>>> Hi,
>>>
>>> Attached patch is to raise an error message when finding an expression
>>> at compile time can't really be solved as a constant for immediate operand.
>>> Without this patch, llvm compiler would crash.
>>>
>>
>> The attached patch seems wrong.  With the attached
>> change, validateTargetOperandClass always returns Match_InvalidOperand for
>> any immediate in this addressing mode.  If the value is a constant value,
>> then it should return Match_Success.
>>
>
> The crash should be addressed by SVN r203762.
>
>
>>
>>
>  --
>>> Thanks,
>>> -Jiangning
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>>
>>
>>
>> --
>> Saleem Abdulrasool
>> compnerd (at) compnerd (dot) org
>>
>
>
>
> --
> Saleem Abdulrasool
> compnerd (at) compnerd (dot) org
>



-- 
Thanks,
-Jiangning
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140313/8fdb2b0a/attachment.html>