<div dir="ltr"><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Are you sure the fix in r203762 is correct? With the trunk, I got the following result, and obviously, the immediate operand is incorrect.</div>
<div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">Thanks,</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small">
-Jiangning</div><div class="gmail_default" style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div class="gmail_default"><div class="gmail_default"><font face="arial, helvetica, sans-serif">$ llvm-mc -triple=armv7-linux-gnuabi -filetype=obj test_label_offset.s -o test_label_offset.o</font></div>
<div class="gmail_default"><font face="arial, helvetica, sans-serif">$ arm-none-linux-gnueabi-objdump -dS test_label_offset.o</font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif"><br></font></div>
<div class="gmail_default"><font face="arial, helvetica, sans-serif">test_label_offset.o:     file format elf32-littlearm</font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif"><br></font></div><div class="gmail_default">
<font face="arial, helvetica, sans-serif"><br></font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif">Disassembly of section .text:</font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif"><br>
</font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif">00000000 <l1-0x4>:</font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif">   0:<span class="" style="white-space:pre">      </span>e3520910 <span class="" style="white-space:pre"> </span>cmp<span class="" style="white-space:pre">       </span>r2, #16, 18<span class="" style="white-space:pre">       </span>; 0x40000</font></div>
<div class="gmail_default"><font face="arial, helvetica, sans-serif">$ cat test_label_offset.s</font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif">.text</font></div><div class="gmail_default">
<font face="arial, helvetica, sans-serif">    cmp r2, #(l2 - l1) >> 6</font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif"><br></font></div><div class="gmail_default"><font face="arial, helvetica, sans-serif">l1:</font></div>
<div class="gmail_default"><font face="arial, helvetica, sans-serif">l2:</font></div><div style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
2014-03-13 15:09 GMT+08:00 Saleem Abdulrasool <span dir="ltr"><<a href="mailto:compnerd@compnerd.org" target="_blank">compnerd@compnerd.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div class="">On Wed, Mar 12, 2014 at 11:23 PM, Saleem Abdulrasool <span dir="ltr"><<a href="mailto:compnerd@compnerd.org" target="_blank">compnerd@compnerd.org</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">

<div>On Wed, Mar 12, 2014 at 11:12 PM, Jiangning Liu <span dir="ltr"><<a href="mailto:liujiangning1@gmail.com" target="_blank">liujiangning1@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div style="font-family:arial,helvetica,sans-serif;font-size:small">


Hi,</div><div style="font-family:arial,helvetica,sans-serif;font-size:small"><br></div><div style="font-family:arial,helvetica,sans-serif;font-size:small">
Attached patch is to raise an error message when finding an expression at compile time can't really be solved as a constant for immediate operand. Without this patch, llvm compiler would crash.</div></div></blockquote>


<div><br></div></div><div>The attached patch seems wrong.  With the attached change, validateTargetOperandClass always returns Match_InvalidOperand for any immediate in this addressing mode.  If the value is a constant value, then it should return Match_Success.</div>

</div></div></div></blockquote><div><br></div></div><div>The crash should be addressed by SVN r203762.</div><div class=""><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div></div></div></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span><font color="#888888"><div></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

<div dir="ltr"><span><font color="#888888">-- <br>

<div dir="ltr"><font face="courier new, monospace">Thanks,</font><div><font face="courier new, monospace">-Jiangning<div style="font-family:arial,helvetica,sans-serif;font-size:small;display:inline">
</div></font></div></div>
</font></span></div>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></font></span></div><span><font color="#888888"><br><br clear="all"><div><br></div>-- <br>Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org
</font></span></div></div>
</blockquote></div></div><div class=""><br><br clear="all"><div><br></div>-- <br>Saleem Abdulrasool<br>compnerd (at) compnerd (dot) org
</div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><font face="courier new, monospace">Thanks,</font><div><font face="courier new, monospace">-Jiangning</font></div></div>
</div>