[PATCH][X86] Refactor peepholes for masked shift amount into a multiclass

Quentin Colombet qcolombet at apple.com
Tue Mar 11 13:31:42 PDT 2014


Hi Adam,

LGTM.

Thanks,
-Quentin

On Mar 3, 2014, at 5:02 PM, Adam Nemet <anemet at apple.com> wrote:

> The peephole (shift x, (and y, 31)) -> (shift x, y) is repeated for each
> integer type and each shift variant.
> 
> To improve this a new multiclass is added that covers all integer types.  The
> shift patterns are now instantiated from this.  I am planning to add new
> instances for rotates as well.
> 
> No functional change intended:
> 
>  * test/CodeGen/X86/shift-and.ll provides coverage
> 
>  * Compared the expanded tablegen output and matched up the defs for these
>    Pat<>s before and after
> 
> <0005-X86-Refactor-peepholes-for-masked-shift-amount-into-.patch>_______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140311/d56f56aa/attachment.html>


More information about the llvm-commits mailing list