<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi Adam,<div><br></div><div>LGTM.</div><div><br></div><div>Thanks,<br><div apple-content-edited="true">
<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">-Quentin</div>
</div>
<br><div style=""><div>On Mar 3, 2014, at 5:02 PM, Adam Nemet <<a href="mailto:anemet@apple.com">anemet@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">The peephole (shift x, (and y, 31)) -> (shift x, y) is repeated for each<br>integer type and each shift variant.<br><br>To improve this a new multiclass is added that covers all integer types. The<br>shift patterns are now instantiated from this. I am planning to add new<br>instances for rotates as well.<br><br>No functional change intended:<br><br> * test/CodeGen/X86/shift-and.ll provides coverage<br><br> * Compared the expanded tablegen output and matched up the defs for these<br> Pat<>s before and after<br><br><span><0005-X86-Refactor-peepholes-for-masked-shift-amount-into-.patch></span>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></div></body></html>