[llvm] r203204 - Replace PROLOG_LABEL with a new CFI_INSTRUCTION.
Rafael EspĂndola
rafael.espindola at gmail.com
Fri Mar 7 14:15:12 PST 2014
On 7 March 2014 16:11, Eric Christopher <echristo at gmail.com> wrote:
> isPosition seems a little awkward. What do you mean by position?
It is. To be honest I was undecided if we should have it or for now
just replace the old isLabel() with isLabel() || isCFIInstruction(). I
am also suspicious of the code that is handling the cfi instruction
specially. It seems that the best representation would be to bundle it
with some real instruction. If a spill is moved, a cfi instruction
should be moved with it, no?
I picked the name mostly at random. Both labels and cfi instructions
don't exist "for real", their are just a position in the code we know
something special about.
Cheers,
Rafael
More information about the llvm-commits
mailing list