[PATCH] [lld] Include reference kind in cycle detector debug

Shankar Easwaran shankare at codeaurora.org
Mon Feb 24 09:37:37 PST 2014


LGTM.

On 2/24/2014 2:15 AM, Nico Rieck wrote:
> On 24.02.2014 06:43, Shankar Easwaran wrote:
>> This patch makes the strings duplicated in the Registry(Reader.cpp,
>> referenceKindToString) and the LayoutPass. I am not sure if there is a
>> way to use the Registry here, but I think it would be better to have a
>> function that could call the Registry to get this information.
> It's possible by passing down a Registry reference to the LayoutPass
> ctor in {Core,ELF,PECOFF,Macho}LinkingContext::addPasses(). The
> LayoutPass would then require ReaderWriter/Reader.h. Would this be
> acceptable? Updated patch attached.
>
> -Nico


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation




More information about the llvm-commits mailing list