[PATCH] [lld] Include reference kind in cycle detector debug

Nico Rieck nico.rieck at gmail.com
Mon Feb 24 00:15:42 PST 2014


On 24.02.2014 06:43, Shankar Easwaran wrote:
> This patch makes the strings duplicated in the Registry(Reader.cpp,
> referenceKindToString) and the LayoutPass. I am not sure if there is a
> way to use the Registry here, but I think it would be better to have a
> function that could call the Registry to get this information.

It's possible by passing down a Registry reference to the LayoutPass
ctor in {Core,ELF,PECOFF,Macho}LinkingContext::addPasses(). The
LayoutPass would then require ReaderWriter/Reader.h. Would this be
acceptable? Updated patch attached.

-Nico
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lld-refkind-debug-output-v2.patch
Type: text/x-patch
Size: 7667 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140224/9b0c5066/attachment.bin>


More information about the llvm-commits mailing list