Improving support for CMake-based applications

Brad King brad.king at kitware.com
Fri Feb 21 07:45:08 PST 2014


On 02/21/2014 10:36 AM, NAKAMURA Takumi wrote:
> I have committed 0003 as r201852 and r201853 split.

Great, thanks.  That split makes sense.

> About 0002, I gave up once although I had similar changes.
> Therefore I didn't commit it.
> To touch this stuff, I think it'd better to redesign llvm-config and
> llvm-config would handle system libs.
> 
> That said, I could accept 0002 if it were required to be extensible.

I don't understand what you mean.  CMake propagates library deps
now so we can just express them in LLVMSupport (or whatever other
libs may need them later) and everything works.

Without 0002 then we have to expose enough implementation details
in LLVMConfig.cmake to allow get_system_libs to work in application
code, and make the applications call it.  My change makes this
much simpler and lets CMake do the job for us.  What is wrong?

-Brad




More information about the llvm-commits mailing list