Improving support for CMake-based applications

NAKAMURA Takumi geek4civic at gmail.com
Fri Feb 21 07:36:35 PST 2014


Brad, sorry that I didn't respond quickly.

2014-02-21 3:14 GMT+09:00 Brad King <brad.king at kitware.com>:
> On 02/10/2014 01:21 PM, Brad King wrote:
>> Please find attached my next patch series.  The first patch adds a
>> sanity check when using tablegen outside LLVM.
>
> I see this as r201229, thanks.

I supposed to post it committed. Sorry again.

>> The other two patches simplify some code in LLVM-Config APIs and in
>> supporting infrastructure (in both the CMake and Makefile build systems).
>
> Please may I call your attention to 0002 and 0003 when you get
> a chance.  r201489 is very similar to one hunk of 0002 and the
> conflict can be easily resolved in favor of r201489.  I'm happy
> to provide rebased patches on request.

I have committed 0003 as r201852 and r201853 split.
It is my preference to split 0003 into two.
I had been confusing 0003 at first. Clenaups may be split, I think. ;)

About 0002, I gave up once although I had similar changes.
Therefore I didn't commit it.
To touch this stuff, I think it'd better to redesign llvm-config and
llvm-config would handle system libs.

That said, I could accept 0002 if it were required to be extensible.

...Takumi



More information about the llvm-commits mailing list