[PATCH v3] Bug 18833 - ARMAsmParser fails to recognize .req directive alias name in capital letters

[Duncan P. N. Exon Smith]

On 2014 Feb 17, at 22:40, Saleem Abdulrasool <compnerd at compnerd.org> wrote:

> Index: test/MC/ARM/dot-req-capital.s
> ===================================================================
> --- test/MC/ARM/dot-req-capital.s (revision 0)
> +++ test/MC/ARM/dot-req-capital.s (working copy)
> @@ -0,0 +1,20 @@
> +@ RUN: llvm-mc -triple=arm < %s | FileCheck %s
> + .syntax unified
> +_foo:
> +
> + OBJECT .req r2
> + mov r4, OBJECT
> + mov r4, oBjEcT
> + .unreq OBJECT
> +
> +_foo2:
> + OBJECT .req r5
> + mov r4, OBJECT
> + .unreq OBJECT

I think you can address Saleem’s point below by changing this latter .unreq to
lowercase (or mixed-case) "object".  The first .unreq covers the uppercase path.

> +
> +@ CHECK-LABEL: _foo:
> +@ CHECK: mov r4, r2
> +@ CHECK: mov r4, r2
> +
> +@ CHECK-LABEL: _foo2:
> +@ CHECK: mov r4, r5
> 
> Your change involves the unreq case, but you arent actually testing the unreq behaviour for case insensitivity.
>