patch for Bug 18833 - ARMAsmParser fails to recognize .req directive alias name in capital letters

[Duncan P. N. Exon Smith]

On 2014 Feb 17, at 17:50, lin zuojian <manjian2006 at gmail.com> wrote:

> It's weird to see a test case already lies in test/MC/ARM/dot-req.s and
> should show this problem.Here is my patch:

Hi Lin,

I just had a look at test/MC/ARM/dot-req.s, and I don’t see any capitalized
names sent to .req.  Certainly, before this can be committed you need to find a
testcase that fails without your change and passes with it.  It looks like the
one you posted to PR18833 is a good start.

Or are you saying that test/MC/ARM/dot-req.s fails in your environment?

Duncan

> 
> Index: lib/Target/ARM/AsmParser/ARMAsmParser.cpp
> ===================================================================
> --- lib/Target/ARM/AsmParser/ARMAsmParser.cpp (revision 201500)
> +++ lib/Target/ARM/AsmParser/ARMAsmParser.cpp (working copy)
> @@ -8243,7 +8243,7 @@
> Error(L, "unexpected input in .unreq directive.");
> return false;
> }
> - RegisterReqs.erase(Parser.getTok().getIdentifier());
> + RegisterReqs.erase(Parser.getTok().getIdentifier().lower());
> Parser.Lex(); // Eat the identifier.
> return false;
> }
> 
> ---
> lin zuojian
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits