[x86][AVX512][FEAT] Memory broadcasting suffixes ({1to8}, {1to16}) support for x86 assembler.

[Zinovy Nis]

Thanks, Alekseyю

It is a typo. It's intended to be:

  bool ErrorAndEatStatement(SMLoc L, const Twine &Msg,
          ArrayRef<SMRange> Ranges = None,
          bool MatchingInlineAsm = false) {
      Parser.eatToEndOfStatement();
      return Error(L, Msg, Ranges, MatchingInlineAsm);   // NOTE: Error
instead of Parser.Error
  }



2014-02-18 14:27 GMT+04:00 Bader, Aleksey A <aleksey.a.bader at intel.com>:

>  Only one minor comment from my side:
>
>
>
> +  bool ErrorAndEatStatement(SMLoc L, const Twine &Msg,
>
> +          ArrayRef<SMRange> Ranges = None,
>
> +          bool MatchingInlineAsm = false) {
>
>
>
> Last two arguments seem to be unnecessary for this function.
>
>
>
> +      Parser.eatToEndOfStatement();
>
> +      return Parser.Error(L, Msg);
>
> +  }
>
> +
>
>
>
>
>
> *From:* iamhypnotoad at gmail.com [mailto:iamhypnotoad at gmail.com] *On Behalf
> Of *Zinovy Nis
> *Sent:* Monday, February 17, 2014 7:39 PM
>
> *To:* llvm-commits at cs.uiuc.edu
> *Cc:* Demikhovsky, Elena; Bader, Aleksey A
> *Subject:* [x86][AVX512][FEAT] Memory broadcasting suffixes ({1to8},
> {1to16}) support for x86 assembler.
>
>
>
> Please review my patch.
>
>
>
> This patch:
>
>    - Makes x86 assembler (llvm-mc) recognize and parse memory
>    broadcasting primitives from AVX512: {1to8} and {1to16}.
>    - Makes x86 assembler accept both Intel- and AT&T-styled AVX512
>    operands primitives. Affects {1to<NUM>}, {%k<NUM>} and {z}.
>    - Adds simple tests for {1to8} and {1to16} parsing.
>    - Slightly clean-ups X86AsmParser.cpp.
>
>
> --------------------------------------------------------------------
> Closed Joint Stock Company Intel A/O
> Registered legal address: Krylatsky Hills Business Park,
> 17 Krylatskaya Str., Bldg 4, Moscow 121614,
> Russian Federation
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140218/27eac635/attachment.html>