<div dir="ltr">Thanks, Alekseyю<div><br></div><div>It is a typo. It's intended to be:</div><div><br></div><div><div> bool ErrorAndEatStatement(SMLoc L, const Twine &Msg,</div><div> ArrayRef<SMRange> Ranges = None,</div>
<div> bool MatchingInlineAsm = false) {</div><div> Parser.eatToEndOfStatement(); </div><div> return Error(L, Msg, Ranges, MatchingInlineAsm); // NOTE: Error instead of Parser.Error</div><div> }</div>
</div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2014-02-18 14:27 GMT+04:00 Bader, Aleksey A <span dir="ltr"><<a href="mailto:aleksey.a.bader@intel.com" target="_blank">aleksey.a.bader@intel.com</a>></span>:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="#0563C1" vlink="#954F72">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Only one minor comment from my side:<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">+ bool ErrorAndEatStatement(SMLoc L, const Twine &Msg,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">+ ArrayRef<SMRange> Ranges = None,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">+ bool MatchingInlineAsm = false) {<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Last two arguments seem to be unnecessary for this function.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">+ Parser.eatToEndOfStatement();<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">+ return Parser.Error(L, Msg);<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">+ }<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">+<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> <a href="mailto:iamhypnotoad@gmail.com" target="_blank">iamhypnotoad@gmail.com</a> [mailto:<a href="mailto:iamhypnotoad@gmail.com" target="_blank">iamhypnotoad@gmail.com</a>]
<b>On Behalf Of </b>Zinovy Nis<br>
<b>Sent:</b> Monday, February 17, 2014 7:39 PM</span></p><div class=""><br>
<b>To:</b> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<b>Cc:</b> Demikhovsky, Elena; Bader, Aleksey A<br>
<b>Subject:</b> [x86][AVX512][FEAT] Memory broadcasting suffixes ({1to8}, {1to16}) support for x86 assembler.<u></u><u></u></div><p></p>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal">Please review my patch. <u></u><u></u></p>
</div><div><div class="h5">
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">This patch:<u></u><u></u></p>
</div>
<div>
<ul type="disc">
<li class="MsoNormal">
Makes x86 assembler (llvm-mc) recognize and parse memory broadcasting primitives from AVX512: {1to8} and {1to16}.<u></u><u></u></li><li class="MsoNormal">
Makes x86 assembler accept both Intel- and AT&T-styled AVX512 operands primitives. Affects {1to<NUM>}, {%k<NUM>} and {z}.<u></u><u></u></li><li class="MsoNormal">
Adds simple tests for {1to8} and {1to16} parsing.<u></u><u></u></li><li class="MsoNormal">
Slightly clean-ups X86AsmParser.cpp.<u></u><u></u></li></ul>
</div>
</div></div></div>
</div>
<p><br>
--------------------------------------------------------------------<br>
Closed Joint Stock Company Intel A/O<br>
Registered legal address: Krylatsky Hills Business Park, <br>
17 Krylatskaya Str., Bldg 4, Moscow 121614, <br>
Russian Federation</p><div class="">
<p>This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.</p></div></div>
</blockquote></div><br></div>