[PATCH] Fix a mingw32 build issue

[Reid Kleckner]

This header isn't exported, so we can name it whatever we want.  It looks
like it used to be called lib/Support/Win32/Win32.h, and then someone moved
it to Windows/Windows.h, producing the ugly conflict.


On Wed, Feb 12, 2014 at 9:36 AM, Anton Korobeynikov <anton at korobeynikov.info
> wrote:

> Probably some LLVM-specific name should be used, if possible. Stuff
> like win32.h and around can easily clash with user's headers
> somewhere...
>
> On Wed, Feb 12, 2014 at 8:29 PM, Aaron Ballman <aaron at aaronballman.com>
> wrote:
> > On Wed, Feb 12, 2014 at 4:59 AM, NAKAMURA Takumi <geek4civic at gmail.com>
> wrote:
> >> Agreed. I have disliked it. Michael, shall we rename it like
> "Support-win32.h" ?
> >>
> >> 2014-02-12 18:54 GMT+09:00 Yaron Keren <yaron.keren at gmail.com>:
> >>> I see now, LLVM has its own Windows.h.  That's confusing, LLVM should
> not
> >>> use standard header file names. This file should be "Windows-LLVM.h" or
> >>> something else unique.
> >
> > I agree; naming it Windows.h was confusing at best. I am okay with
> > Windows-LLVM.h, but would also be okay with Win32.h, or
> > Win32Support.h.
> >
> > ~Aaron
>
>
>
> --
> With best regards, Anton Korobeynikov
> Faculty of Mathematics and Mechanics, Saint Petersburg State University
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140212/d0605e80/attachment.html>