[PATCH] Fix a mingw32 build issue

Anton Korobeynikov anton at korobeynikov.info
Wed Feb 12 09:36:43 PST 2014


Probably some LLVM-specific name should be used, if possible. Stuff
like win32.h and around can easily clash with user's headers
somewhere...

On Wed, Feb 12, 2014 at 8:29 PM, Aaron Ballman <aaron at aaronballman.com> wrote:
> On Wed, Feb 12, 2014 at 4:59 AM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
>> Agreed. I have disliked it. Michael, shall we rename it like "Support-win32.h" ?
>>
>> 2014-02-12 18:54 GMT+09:00 Yaron Keren <yaron.keren at gmail.com>:
>>> I see now, LLVM has its own Windows.h.  That's confusing, LLVM should not
>>> use standard header file names. This file should be "Windows-LLVM.h" or
>>> something else unique.
>
> I agree; naming it Windows.h was confusing at best. I am okay with
> Windows-LLVM.h, but would also be okay with Win32.h, or
> Win32Support.h.
>
> ~Aaron



-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University



More information about the llvm-commits mailing list