[PATCH] Fix a mingw32 build issue

NAKAMURA Takumi geek4civic at gmail.com
Wed Feb 12 01:45:18 PST 2014


2014-02-12 17:28 GMT+09:00 Yaron Keren <yaron.keren at gmail.com>:
> Hi,
>
> While at it, #include "Windows.h" should be #include <Windows.h>.

No. "llvm/lib/Support/Windows/Windows.h" should satisfy there.
I'll apply Alex's after bots became green. I think it's reasonable.

...Takumi

>
> Yaron
>
>
>
> 2014-02-12 10:18 GMT+02:00 Alex Crichton <alex at crichton.co>:
>>
>> I found that swapping the order of some header files helped fix a
>> build issue that we're seeing on mingw32. Without the swap, windows.h
>> was being included before _WIN32_WINNT was being defined and the
>> CreateHardLinkW function was #ifdef'd out.
>>
>> It looks like the header is mainly used to get the SHGetFolderPathW
>> function, so I don't think that there'll be much fallout from the
>> switch.
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



More information about the llvm-commits mailing list