[compiler-rt] r200914 - tsan: improve error message for Go

[Kostya Serebryany]

On Thu, Feb 6, 2014 at 1:22 PM, Dmitry Vyukov <dvyukov at google.com> wrote:

> Author: dvyukov
> Date: Thu Feb  6 03:22:29 2014
> New Revision: 200914
>
> URL: http://llvm.org/viewvc/llvm-project?rev=200914&view=rev
> Log:
> tsan: improve error message for Go
>
>
> Modified:
>     compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.cc
>
> Modified:
> compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.cc
> URL:
> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.cc?rev=200914&r1=200913&r2=200914&view=diff
>
> ==============================================================================
> --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.cc
> (original)
> +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.cc
> Thu Feb  6 03:22:29 2014
> @@ -130,8 +130,13 @@ u32 ThreadRegistry::CreateThread(uptr us
>      tctx = context_factory_(tid);
>      threads_[tid] = tctx;
>    } else {
> +#ifndef SANITIZER_GO
>

Where possible, please prefer if (SANITIZER_GO) over #ifdef SANITIZER_GO


>      Report("%s: Thread limit (%u threads) exceeded. Dying.\n",
>             SanitizerToolName, max_threads_);
> +#else
> +    Printf("race: limit on %u simultaneously alive goroutines is
> exceeded,"
> +        " dying\n", max_threads_);
> +#endif
>      Die();
>    }
>    CHECK_NE(tctx, 0);
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20140206/cea9c87b/attachment.html>