<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Feb 6, 2014 at 1:22 PM, Dmitry Vyukov <span dir="ltr"><<a href="mailto:dvyukov@google.com" target="_blank">dvyukov@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: dvyukov<br>
Date: Thu Feb  6 03:22:29 2014<br>
New Revision: 200914<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=200914&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=200914&view=rev</a><br>
Log:<br>
tsan: improve error message for Go<br>
<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.cc<br>
<br>
Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.cc?rev=200914&r1=200913&r2=200914&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.cc?rev=200914&r1=200913&r2=200914&view=diff</a><br>

==============================================================================<br>
--- compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.cc (original)<br>
+++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_thread_registry.cc Thu Feb  6 03:22:29 2014<br>
@@ -130,8 +130,13 @@ u32 ThreadRegistry::CreateThread(uptr us<br>
     tctx = context_factory_(tid);<br>
     threads_[tid] = tctx;<br>
   } else {<br>
+#ifndef SANITIZER_GO<br></blockquote><div><br></div><div>Where possible, please prefer if (SANITIZER_GO) over #ifdef SANITIZER_GO</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

     Report("%s: Thread limit (%u threads) exceeded. Dying.\n",<br>
            SanitizerToolName, max_threads_);<br>
+#else<br>
+    Printf("race: limit on %u simultaneously alive goroutines is exceeded,"<br>
+        " dying\n", max_threads_);<br>
+#endif<br>
     Die();<br>
   }<br>
   CHECK_NE(tctx, 0);<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>